Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

types(emits): simplify types #9788

Merged
merged 3 commits into from
Dec 11, 2023
Merged

types(emits): simplify types #9788

merged 3 commits into from
Dec 11, 2023

Conversation

Alfred-Skyblue
Copy link
Member

Simplify types to make them easier to read.

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 9, 2023

Size Report

Bundles

File Size Gzip Brotli
runtime-dom.global.prod.js 87 kB 33.1 kB 29.9 kB
vue.global.prod.js 133 kB 49.9 kB 44.7 kB

Usages

Name Size Gzip Brotli
createApp 48.3 kB 19 kB 17.4 kB
createSSRApp 51.5 kB 20.3 kB 18.5 kB
defineCustomElement 50.7 kB 19.8 kB 18 kB
overall 61.7 kB 23.9 kB 21.7 kB

@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Dec 9, 2023 •
edited
Loading

CodSpeed Performance Report

Merging #9788 will not alter performance

Comparing Alfred-Skyblue:types/eimts-simplify (b133c8c) with main (60415b5)

Summary

✅ 53 untouched benchmarks

@yyx990803
Copy link
Member

/ecosystem-ci run

@vue-bot
Copy link
Contributor

vue-bot commented Dec 11, 2023

📝 Ran ecosystem CI: Open

suite result latest scheduled
language-tools ❌ failure ❌ failure
nuxt ✅ success ✅ success
pinia ✅ success ✅ success
quasar ✅ success ✅ success
router ✅ success ✅ success
test-utils ✅ success ✅ success
vant ✅ success ✅ success
vite-plugin-vue ✅ success ✅ success
vitepress ✅ success ✅ success
vue-i18n ✅ success ✅ success
vue-macros ✅ success ✅ success
vuetify ✅ success ✅ success
vueuse ✅ success ✅ success
vue-simple-compiler ✅ success ✅ success

pikax
pikax approved these changes Dec 11, 2023
View reviewed changes
Copy link
Member

@pikax pikax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pikax pikax added scope: types 🧹 p1-chore Priority 1: this doesn't change code behavior. labels Dec 11, 2023
@yyx990803 yyx990803 merged commit a6503e3 into vuejs:main Dec 11, 2023
13 checks passed
@Alfred-Skyblue Alfred-Skyblue deleted the types/eimts-simplify branch December 11, 2023 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pikax pikax pikax approved these changes

Assignees
No one assigned
Labels
🧹 p1-chore Priority 1: this doesn't change code behavior. scope: types
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Alfred-Skyblue @yyx990803 @vue-bot @pikax